pytorch
b0ac9bfb - Add warning about should_drop for JIT coverage plug-in (#57961)

Commit
4 years ago
Add warning about should_drop for JIT coverage plug-in (#57961) Summary: This adds a comment above `should_drop` to prevent someone from inadvertently breaking JIT coverage by renaming the function without updating the correct references. The current JIT plug-in uses `should_drop` to figure out which code is going to be JIT'd. If the function is named differently, the plug-in would also need to be updated. Question: I understand this may not be the cleanest solution. Would a cleaner solution be to create a dummy function that would simply exist for the JIT plug-in? I did not immediately do that as that may be adding unnecessary code complexity in torch.jit. Pull Request resolved: https://github.com/pytorch/pytorch/pull/57961 Reviewed By: samestep Differential Revision: D28933587 Pulled By: janeyx99 fbshipit-source-id: 260aaf7b11f07de84a81d6c3554c4a5ce479d623
Author
Parents
Loading