pytorch
b0b5f3c6 - Fix gumbel cdf (#91698)

Commit
1 year ago
Fix gumbel cdf (#91698) Fix `Gumbel.cdf` function. **Description** When transformed parameters is outside of the support of underlying Uniform distribution. This makes behavior of `Gumbel.cdf` consistent with other `TransformedDistribution` that pass value of validate_args to the base distribution. **Issue** running `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` would cause `ValueError` exception from `_validate_sample` **Testing** Test was added to the `test_distributions.py` to check if `Gumbel(0.0,1.0,validate_args=False).cdf(20.0)` successfully returns `1.0` This is a second attempt to push changes , after https://github.com/pytorch/pytorch/pull/82488 Pull Request resolved: https://github.com/pytorch/pytorch/pull/91698 Approved by: https://github.com/fritzo, https://github.com/zou3519
Author
Committer
Parents
Loading