pytorch
b5c464d5 - Make Future store weak pointers to storages (#60943)

Commit
3 years ago
Make Future store weak pointers to storages (#60943) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/60943 In https://github.com/pytorch/pytorch/pull/60470 we made Future store Storages rather than store references to their DataPtrs (because these references could go stale...). However this meant that the Future could keep the Storage alive, and thus keep its memory allocated, even after the user was done with it. We fix it here by instead storing a weak ptr to that Storage (well, in fact to the StorageImpl, but it's the same). ghstack-source-id: 133295799 Test Plan: CI Reviewed By: mrshenli Differential Revision: D29454104 fbshipit-source-id: d36dee00a4841c087bb7b3f5bc39e0459f209cdb
Author
lw lw
Parents
Loading