pytorch
bdb42189 - Remove some wildcards from mypy configs (#56645)

Commit
3 years ago
Remove some wildcards from mypy configs (#56645) Summary: See https://github.com/pytorch/pytorch/pull/56523#issuecomment-823562134 for context. Basically the idea is that people (including myself) keep assuming that the single-asterisk `*` wildcard means "match in this directory and in its subdirectories", which is _not_ true. Removing the wildcards thus reduces confusion. Ideally I would like to remove _all_ of these wildcards and then add a lint to disallow them in the future (and also greatly simplify the pattern-matching logic in `tools/mypy_wrapper.py`; see https://github.com/pytorch/pytorch/issues/55702 for context), but currently this one can't be removed: ``` tools/autograd/*.py, ``` That is because there is a file called `tools/autograd/templates/annotated_fn_args.py` (added in https://github.com/pytorch/pytorch/issues/41575) which is not a valid Python file and thus cannot be checked by `mypy`. ezyang would it be possible to rename that file to use a suffix other than `.py`? Pull Request resolved: https://github.com/pytorch/pytorch/pull/56645 Test Plan: ``` $ mypy Success: no issues found in 1317 source files $ mypy --config=mypy-strict.ini Success: no issues found in 72 source files ``` The numbers of source files should be the same before and after this PR. Reviewed By: ezyang Differential Revision: D27925207 Pulled By: samestep fbshipit-source-id: c17faf73665a75393d3109346a1138c2af023abb
Author
Parents
Loading