pytorch
bf675899 - Escape curly brackets in FxGraphDrawer _typename (#83604)

Commit
3 years ago
Escape curly brackets in FxGraphDrawer _typename (#83604) Summary: Encountered `Error: bad label format` from dot (i.e. graphviz) when benchmarking models that have dict-like structure. The root cause was that curly brackets were not properly escaped, like this example P522499127 (unescaped curly brackets in target= string) This diff insert the fix in FxGraphDrawer, since many of these graph generation codes rely on that class. (Modified summary before exporting to GitHub PR) Test Plan: ``` CUDA_VISIBLE_DEVICES=7 buck run mode/opt -c python.package_style=inplace //hpc/new/models/feed/benchmark:feed_lower_benchmark -- --model-name={INSERT IFR QE MODEL NAME HERE} --batch-iter 100 --batch-size 768 --num-gpu 1 --lower-presets {INSERT ITS PRESET} ``` Will not encounter dot errors after this diff. (Modified test plan before exporting to GitHub PR) Reviewed By: yinghai Differential Revision: D38758827 Pull Request resolved: https://github.com/pytorch/pytorch/pull/83604 Approved by: https://github.com/yinghai, https://github.com/jianyuh
Author
Sungmin Cho
Committer
Parents
Loading