pytorch
c0ce4b0d - make refs executor handle kwargs (#79858)

Commit
2 years ago
make refs executor handle kwargs (#79858) Mostly fixes #78923 I had to disable function patching in fx for functions with kwonly args, see https://github.com/pytorch/pytorch/compare/ngimel/make_fx_fix?expand=1#diff-090b22122be0779cd14afd2ebaf20d1e7c0bfe837e9eefa1d84e7521bb1defc6R446, cc @jamesr66a But it looks like it was doing weird things anyway - it was patching signature of wrapped function with arbitrary local vars from wrapper, that can't be right, but I don't know what the intent there is. A lot of functions now fail with nvfuser executor, and some still fail with aten, although with the different errors than before. Edit: undid the change to _symbolic_script.py, turns out inspect.unwrapping function is not needed, and fx never sees kwargs. cc @IvanYashchuk, @Chillee Pull Request resolved: https://github.com/pytorch/pytorch/pull/79858 Approved by: https://github.com/IvanYashchuk, https://github.com/mruberry
Author
Natalia Gimelshein
Committer
Parents
Loading