pytorch
c219b55b - Use standard __func__ macro in symbolic shape. (#89264)

Commit
3 years ago
Use standard __func__ macro in symbolic shape. (#89264) Summary: I saw the following issue only on Windows build in PR #88767: ``` RuntimeError: AttributeError: 'SymNode' object has no attribute 'torch::impl::PythonSymNodeImpl::ge' ``` It's only on Windows because we get the attributes of SymNode in C++ with `__FUNCTION__` macro, which is not in C++ standard, therefore has platform specific behavior. In this case, MSVC will include a function's namespace and class name, which is not intended here. Instead we should use `__func__`. see: https://en.cppreference.com/w/cpp/language/function#Function_definition godbolt example to show the difference: https://godbolt.org/z/PGfvecxPx Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: https://github.com/pytorch/pytorch/pull/89264 Approved by: https://github.com/ezyang
Author
Committer
Parents
Loading