pytorch
c7dd5f89 - Fix #33562 (uncaught domain_error on macOS) (#34301)

Commit
4 years ago
Fix #33562 (uncaught domain_error on macOS) (#34301) Summary: Tries to fix https://github.com/pytorch/pytorch/issues/33562 by raising `std::runtime_error` instead of `std::domain_error`. * The Python tests already expect `RuntimeError` so this shouldn't affect Python users of PyTorch. * If someone out there is using C10 or ATen from C++ and tries to catch `std::domain_error` specifically, this fix would break their code. Hopefully that's not the case. Alternative to this PR is someone try to really get to the bottom of why `std::domain_error` isn't being caught. Pull Request resolved: https://github.com/pytorch/pytorch/pull/34301 Differential Revision: D20344579 Pulled By: ezyang fbshipit-source-id: d5f3045085a2f75b71b864335ebf44991d0cad80
Author
Parents
Loading