[PyTorch] Align function parameters across declaration and definition for max pool 2d (#54105)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/54105
This is preparing XNNPACK to be enabled in Windows. For some reason Windows clang doesn't think functions taking `float` and `const float` to have the same signature and thus throwing link errors like:
```
lld-link: error: undefined symbol: bool __cdecl at::native::xnnpack::use_max_pool2d(class at::Tensor const &, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, bool, float, float)
>>> referenced by C:\open\fbsource\buck-out\gen\f84e6a81\xplat\caffe2\pt_ops_full_template_registration\aten\src\ATen\native\Pooling.cpp:127
>>> libpt_ops_fullWindows.lib(out.obj):(class at::Tensor __cdecl at::native::max_pool2d(class at::Tensor const &, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, bool))
lld-link: error: undefined symbol: class at::Tensor __cdecl at::native::xnnpack::max_pool2d(class at::Tensor const &, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, bool, float, float)
>>> referenced by C:\open\fbsource\buck-out\gen\f84e6a81\xplat\caffe2\pt_ops_full_template_registration\aten\src\ATen\native\Pooling.cpp:129
>>> libpt_ops_fullWindows.lib(out.obj):(class at::Tensor __cdecl at::native::max_pool2d(class at::Tensor const &, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, class c10::ArrayRef<__int64>, bool))
```
Declaration: `src/ATen/native/xnnpack/Engine.h`
Definition: `src/ATen/native/xnnpack/MaxPooling.cpp`
Reference: `src/ATen/native/Pooling.cpp`
Test Plan: build succeeded
Reviewed By: kimishpatel
Differential Revision: D27097201
fbshipit-source-id: ab557f608713840ee0a65b252fa875624ddd502f
