pytorch
d6c29b1d - Deduplicate legacy _ctor and _new Python bindings (#73822)

Commit
2 years ago
Deduplicate legacy _ctor and _new Python bindings (#73822) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/73822 I guess hypothetically the logic duplication here is a faux amis because we could say that the constructor and new method should evolve APIs independently... but nah, it's not worth it. There is only very slight differences between the two functions: different error messages, and the new method does extra checks to make sure the requested types are consistent with the base Tensor. But I need to refactor this code and I really don't want to do the refactor twice. So dedupe first. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: anjali411 Differential Revision: D34665171 Pulled By: ezyang fbshipit-source-id: bd40ec7f6e694bfeff4e4aaab2f4e95cea250b65 (cherry picked from commit 10a03926d8d8f36506c9a3d62cf2c380f559b00b)
Author
Committer
Parents
Loading