pytorch

d7e4a379 - [C++ API Parity] LBFGS optimizer step() update and added closure to the Optimizer step() function (#34564)

[C++ API Parity] LBFGS optimizer step() update and added closure to the Optimizer step() function (#34564) Summary: Follow-ups after this PR: * Remove `LossClosureOptimizer`, and merge `Optimizer` into `OptimizerBase` (and rename the merged class to Optimizer) * Merge the LBFGS-specific serialize test function and the generic `test_serialize_optimizer` function, possibly by passing a bool `has_only_global_state` flag into the `test_serialize_optimizer` function to denote whether `size()` should be equal to 1 or 2? * https://github.com/pytorch/pytorch/pull/34564#discussion_r393780303 * It seems that we don't have the equivalent `XORConvergence_LBFGS` test like the other optimizers, and it would be good to add one * Remove mentions of `parameters_` in optimizer.cpp, de-virtualize all functions, and remove the `OptimizerBase(std::vector<Tensor> parameters)` constructor from `OptimizerBase` Pull Request resolved: https://github.com/pytorch/pytorch/pull/34564 Test Plan: Imported from GitHub, without a `Test Plan:` line. Differential Revision: D20495701 Pulled By: anjali411 fbshipit-source-id: 6d35286d2decb6f7dff93d9d3e57515770666622