pytorch
d8093105 - Update linter to validate file names are compatible across OSes (#78736)

Commit
3 years ago
Update linter to validate file names are compatible across OSes (#78736) Fixes https://github.com/pytorch/pytorch/issues/74341 Ensure all files have names that are valid across all operating systems, including checking for a trailing white space Note: This is not a fully comprehensive check since there are various quicks some the OSes have ([namely Windows](https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file)) that make it reserves certain names and characters. Still, it covers the file names we are most likely to run into, including one that caused https://github.com/pytorch/pytorch/commit/7cf9b942daa824267ec3902f1026b3e6353561ff to need a revert ## Testing Created another PR with four invalid file names and verified that the linter caught all of them: https://github.com/pytorch/pytorch/runs/6712731938?check_suite_focus=true <img width="1093" alt="image" src="https://user-images.githubusercontent.com/4468967/171684679-c968fecf-9bc5-480c-9e18-012def25df06.png"> Pull Request resolved: https://github.com/pytorch/pytorch/pull/78736 Approved by: https://github.com/seemethere, https://github.com/atalman
Author
Committer
Parents
Loading