pytorch

db601434 - Bug fix (#65105)

Bug fix (#65105) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/65105 Using buildErrorMessage in external_functions.cpp was breaking build target nnc_cpu_backend_lib as buildErrorMessage is defined in tensorexpr/kernel.cpp which is not included in mobile builds and we don't want to include it in mobile builds. Also buildErrorMessage wraps error messages for fuser whereas nnc_aten_conv2d is now only used in AOT workflow and not called by the fuser. So wrapping assertion failures with fuser error message would be misleading for AOT workflow. Test Plan: Before fix: ``` + buck build //xplat/caffe2/fb/lite_predictor:lite_predictor_nnc Downloading... 3/3 artifacts, 24.81 Kbytes, 0.0% cache miss (for updated rules) Building... 1.7 sec (99%) 4639/4641 jobs, 3/4641 updated - //xplat/caffe2/fb/lite_predictor:lite_predictor_nnc#binary... 0.7 sec (running c++ link[0.6 sec]) Command failed with exit code 1. command: [/data/users/priyaramani/fbsource/buck-out/cells/fbcode/gen/aab7ed39/tools/build/buck/wrappers/__ld__/ld.sh, --ld=/data/users/priyaramani/fbsource/fbcode/third-party-buck/platform009/build/llvm-fb/9.0.0/bin/clang++, --cc=/data/users/priyaramani/fbsource/buck-out/cells/fbcode/gen/aab7ed39/tools/build/buck/wrappers/__fbc... <truncated> ... stderr: clang-9: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] ld.lld: error: undefined symbol: torch::jit::tensorexpr::buildErrorMessage(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) >>> referenced by external_functions.cpp:69 (xplat/caffe2/torch/csrc/jit/tensorexpr/external_functions.cpp:69) >>> ../nnc_cpu_backend_lib#compile-external_functions.cpp.o50e02bc2,platform009-clang/torch/csrc/jit/tensorexpr/external_functions.cpp.o:(nnc_aten_conv2d) in archive /data/users/priyaramani/fbsource/buck-out/gen/aab7ed39/xplat/caffe2/nnc_cpu_backend_lib#platform009-clang,static/libnnc_cpu_backend_lib.a clang-9: error: linker command failed with exit code 1 (use -v to see invocation) When running <c++ link>. When building rule //xplat/caffe2/fb/lite_predictor:lite_predictor_nnc#binary (ovr_config//platform/linux:x86_64-fbcode). clang-9: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] ld.lld: error: undefined symbol: torch::jit::tensorexpr::buildErrorMessage(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) >>> referenced by external_functions.cpp:69 (xplat/caffe2/torch/csrc/jit/tensorexpr/external_functions.cpp:69) >>> ../nnc_cpu_backend_lib#compile-external_functions.cpp.o50e02bc2,platform009-clang/torch/csrc/jit/tensorexpr/external_functions.cpp.o:(nnc_aten_conv2d) in archive /data/users/priyaramani/fbsource/buck-out/gen/aab7ed39/xplat/caffe2/nnc_cpu_backend_lib#platform009-clang,static/libnnc_cpu_backend_lib.a clang-9: error: linker command failed with exit code 1 (use -v to see invocation) Command failed with exit code 1. command: [/data/users/priyaramani/fbsource/buck-out/cells/fbcode/gen/aab7ed39/tools/build/buck/wrappers/__ld__/ld.sh, --ld=/data/users/priyaramani/fbsource/fbcode/third-party-buck/platform009/build/llvm-fb/9.0.0[DEBUG kernel.cpp:2766] } ``` After fix: ``` + buck build //xplat/caffe2/fb/lite_predictor:lite_predictor_nnc Action graph will be rebuilt because files have been added or removed. clang-9: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] Downloaded 11/15 artifacts, 78.37 Kbytes, 15.4% cache miss (for updated rules) Building: finished in 7.4 sec (100%) 4718/4718 jobs, 46/4718 updated Total time: 7.5 sec More details at https://www.internalfb.com/intern/buck/build/b87be016-340c-49f8-b832-0c1de70aae9e ``` Reviewed By: ZolotukhinM Differential Revision: D30975952 fbshipit-source-id: 85c028cc6af63c03b505b51302f5158c23e1a047