pytorch

e2216ada - Properly formats errors rising up from C++ extension compilation (#22445)

Properly formats errors rising up from C++ extension compilation (#22445) Summary: Here's a C++ extension with a missing semicolon: ```python torch.utils.cpp_extension.load_inline('test', 'int main() { return 0 }') ``` which currently generates this error ``` RuntimeError: Error building extension 'test_v6': b'[1/2] c++ -MMD -MF main.o.d - DTORCH_EXTENSION_NAME=test_v6 -DTORCH_API_INCLUDE_EXTENSION_H -isystem /opt/conda/lib/python3.7/site-packages/torch/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/TH -isystem /opt/conda/lib/python3.7/site-packages/torch/include/THC -isystem /opt/conda/include/python3.7m -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++11 -c /tmp/torch_extensions/test/main.cpp -o main.o\nFAILED: main.o \nc++ -MMD -MF main.o.d - DTORCH_EXTENSION_NAME=test_v6 -DTORCH_API_INCLUDE_EXTENSION_H -isystem /opt/conda/lib/python3.7/site-packages/torch/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/TH -isystem /opt/conda/lib/python3.7/site-packages/torch/include/THC -isystem /opt/conda/include/python3.7m -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++11 -c /tmp/torch_extensions/test/main.cpp -o main.o\n/tmp/torch_extensions/test/main.cpp: In function \xe2\x80\x98int main()\xe2\x80\x99:\n/tmp/torch_extensions/test/main.cpp:2:23: error: expected \xe2\x80\x98;\xe2\x80\x99 before \xe2\x80\x98}\xe2\x80\x99 token\n int main() { return 0 }\n ^\nninja: build stopped: subcommand failed.\n' ``` After this PR, the error is ``` RuntimeError: Error building extension 'test': [1/2] c++ -MMD -MF main.o.d - DTORCH_EXTENSION_NAME=test -DTORCH_API_INCLUDE_EXTENSION_H -isystem /opt/conda/lib/python3.7/site-packages/torch/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/TH -isystem /opt/conda/lib/python3.7/site-packages/torch/include/THC -isystem /opt/conda/include/python3.7m -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++11 -c /tmp/torch_extensions/test/main.cpp -o main.o FAILED: main.o c++ -MMD -MF main.o.d -DTORCH_EXTENSION_NAME=test - DTORCH_API_INCLUDE_EXTENSION_H -isystem /opt/conda/lib/python3.7/site- packages/torch/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.7/site- packages/torch/include/TH -isystem /opt/conda/lib/python3.7/site-packages/torch/include/THC -isystem /opt/conda/include/python3.7m -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++11 -c /tmp/torch_extensions/test/main.cpp -o main.o /tmp/torch_extensions/test/main.cpp: In function ‘int main()’: /tmp/torch_extensions/test/main.cpp:2:23: error: expected ‘;’ before ‘}’ token int main() { return 0 } ^ ninja: build stopped: subcommand failed. ``` which is a lot easier to read. Pull Request resolved: https://github.com/pytorch/pytorch/pull/22445 Differential Revision: D16094205 Pulled By: ezyang fbshipit-source-id: 21043344aac260dc3e4e04d6a42898507bb840e4