pytorch

e2ee87d4 - Fix segfault on mac when running vulkan tests (#120337)

Fix segfault on mac when running vulkan tests (#120337) Summary: Vulkan gtests were segfaulting on mac because the memory for barriers can get destroyed after the local function(CommandBuffer::insert_barrier) exits where it is created. Since we provide this barrier pointer to vulkan library it needs to be around even after the function exit, else we get crashes. Test Plan: See that there is no segfault on mac with fix and tests can run: Compile gtests: buck2 build --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_quantized_api_test_binAppleMac\#macosx-arm64 -c pt.vulkan_full_precision=1 --show-output" Crash w/o diff bash-3.2$ buck-out//v2/gen/fbsource/xplat/caffe2/pt_vulkan_quantized_api_test_binAppleMac Running main() from third-party/googletest/1.14.0/googletest/googletest/src/gtest_main.cc [==========] Running 85 tests from 1 test suite. [----------] Global test environment set-up. [----------] 85 tests from VulkanAPITest [ RUN ] VulkanAPITest.uniform_buffer_copy [ OK ] VulkanAPITest.uniform_buffer_copy (88 ms) [ RUN ] VulkanAPITest.copy_to_buffer Segmentation fault: 11 With diff there is no crash: bash-3.2$ buck-out//v2/gen/fbsource/xplat/caffe2/pt_vulkan_quantized_api_test_binAppleMac Running main() from third-party/googletest/1.14.0/googletest/googletest/src/gtest_main.cc [==========] Running 85 tests from 1 test suite. [----------] Global test environment set-up. [----------] 85 tests from VulkanAPITest [ RUN ] VulkanAPITest.uniform_buffer_copy [ OK ] VulkanAPITest.uniform_buffer_copy (296 ms) ..... [ FAILED ] VulkanAPITest.gelu_quint8_self (23 ms) [----------] 85 tests from VulkanAPITest (1494 ms total) [----------] Global test environment tear-down [==========] 85 tests from 1 test suite ran. (1494 ms total) [ PASSED ] 72 tests. [ FAILED ] 13 tests, listed below: [ FAILED ] VulkanAPITest.linear_2d_flat [ FAILED ] VulkanAPITest.linear_2d_small [ FAILED ] VulkanAPITest.linear_2d_large [ FAILED ] VulkanAPITest.linear_3d_flat [ FAILED ] VulkanAPITest.linear_3d_small [ FAILED ] VulkanAPITest.linear_3d_large [ FAILED ] VulkanAPITest.linear_4d_flat [ FAILED ] VulkanAPITest.linear_4d_small [ FAILED ] VulkanAPITest.linear_4d_large [ FAILED ] VulkanAPITest.gelu_qint8 [ FAILED ] VulkanAPITest.gelu_qint8_self [ FAILED ] VulkanAPITest.gelu_quint8 [ FAILED ] VulkanAPITest.gelu_quint8_self The above failing tests were failing before as well and are being worked on. Differential Revision: D54023146 Pull Request resolved: https://github.com/pytorch/pytorch/pull/120337 Approved by: https://github.com/SS-JIA