[PyTorch] s/__attribute__((__noinline__))/__attribute__((noinline))/ (#52362)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/52362
AFAICT, it is documented to be the latter and not the former.
GCC: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes
Clang: https://clang.llvm.org/docs/AttributeReference.html
Both versions work in the oldest and newest GCC & Clang versions on Godbolt: https://godbolt.org/z/s6f4PW
So why change?
1) lack of underscores matches the documentation
2) AMD HIP defines `__noinline__` as a macro, which doesn't play well with the underscore version.
See https://github.com/ROCm-Developer-Tools/HIP/blob/2080cc113a2d767352b512b9d24c0620b6dee790/include/hip/hcc_detail/host_defines.h#L54
ghstack-source-id: 121875424
Test Plan: Rely on existing CI
Reviewed By: bhosmer
Differential Revision: D26488991
fbshipit-source-id: 6cfcdfd41c58170659e263cd519ac5359ffd5d46
