pytorch

edf1868e - Fix test_doc_template regex (#81755)

Fix test_doc_template regex (#81755) ### The problem This original regex abuses .* in combination with `re.DOTALL` and leads to a catastrophic backtracking perf issue when there is no match. When it happens, test_doc_template will run "forever" and timeout. Here is an example timeout test https://github.com/pytorch/pytorch/runs/7413337595 Another minor issue with this regex is that it won't matches concatenated doc string like `"""FOO""" + """BAR"""`, which is used for some API `_torch_docs.py` ### The fix * Remove most of the match all .* usage. I have tested to make sure that the test finishes even when there is no match, i.e. it fails successfully * Update the regex to match all the following cases before and after linting (You can also try it out on https://pythex.org): BEFORE ``` add_docstr(torch.abs, r""" abs(input, *, out=None) -> Tensor Computes the absolute value of each element in :attr:`input`. .. math:: \text{out}_{i} = |\text{input}_{i}| """ + r""" Args: {input} Keyword args: {out} Example:: >>> torch.abs(torch.tensor([-1, -2, 3])) tensor([ 1, 2, 3]) """.format(**common_args)) add_docstr(torch.absolute, r""" absolute(input, *, out=None) -> Tensor Alias for :func:`torch.abs` """) ``` AFTER ``` add_docstr( torch.abs, r""" abs(input, *, out=None) -> Tensor Computes the absolute value of each element in :attr:`input`. .. math:: \text{out}_{i} = |\text{input}_{i}| """ + r""" Args: {input} Keyword args: {out} Example:: >>> torch.abs(torch.tensor([-1, -2, 3])) tensor([ 1, 2, 3]) """.format( **common_args ), ) add_docstr( torch.absolute, r""" absolute(input, *, out=None) -> Tensor Alias for :func:`torch.abs` """, ) ``` This will unblock https://github.com/pytorch/pytorch/pull/81643 Pull Request resolved: https://github.com/pytorch/pytorch/pull/81755 Approved by: https://github.com/atalman