pytorch
efb1895f - [caffe2] use snprintf() instead of sprintf() in the Checkpoint operator (#53434)

Commit
3 years ago
[caffe2] use snprintf() instead of sprintf() in the Checkpoint operator (#53434) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/53434 Use `snprintf()` to avoid buffer overflows. Also only throw an exception on error, instead of crashing the entire application. A failure can occur if the caller supplies an invalid format string. ghstack-source-id: 123401582 Test Plan: Ran the checkpoint tests: buck test caffe2/caffe2/python/operator_test:checkpoint_test Verified that the checkpoint file names logged in the output are the same before and after this change. I also tested manually changed the initial buffer size to 1 to confirm that the code works when the initial buffer size is too small. I considered updating the checkpoint_test.py code to test using long db names that would exceed this limit, but I figured that long filenames was likely to cause other problems on some platforms (Windows has a maximum path length of 260 characters up until pretty recent releases). Differential Revision: D26863355 fbshipit-source-id: 8fc24faa2a8dd145471067718d323fdc8ce055d6
Author
Parents
Loading