pytorch
fced51ea - [torch][distributed] Check for file existence before invoking cleanup logic in FileStore destructor (#68603)

Commit
3 years ago
[torch][distributed] Check for file existence before invoking cleanup logic in FileStore destructor (#68603) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/68603 FileStore is frequently used from the python lang, which has GC. This means, that users of FileStore from python do not have control over when FileStore destructor is invoked. If the directory for file store is created by some external logic, that has cleanup procedure, this procedure may have a race condition with the logic in the FileStore destructor. The diff adds check for file access in destructor before actually invoking the cleanup. In long term, it makes sense to move out the cleanup logic out of the destructor to a separate method. Test Plan: CI Stress tests: `buck test mode/dev-nosan //torchrec/examples/dlrm/tests:test_dlrm_main -- --exact 'torchrec/examples/dlrm/tests:test_dlrm_main - torchrec.examples.dlrm.tests.test_dlrm_main.MainTest: test_main_function' --run-disabled --jobs 18 --stress-runs 20 --record-results` Reviewed By: colin2328 Differential Revision: D32535470 fbshipit-source-id: 6f421f2e7b0d9ac9c884a1db2f7e5a94fc59fc0e
Author
Parents
Loading