[stdlib] Fix and clean up 'split' documentation
* Collection's default implementation for
split(separator:maxSplits:omittingEmptySubsequences:) had the wrong
version of the documentation.
* Some parameter docs were missing default values.
* Fixed an indentation issue.
* Reviewed the post-index-change TODO comments throughout
Collection.swift.