swift

bea00bb9 - [cmake] Bump minimum cmake to version 3.24 and place -- after cmake -E env's options are passed.

[cmake] Bump minimum cmake to version 3.24 and place -- after cmake -E env's options are passed. `cmake -E env` is CMake's helper for running a child command with extra environment variables. Its argument grammar is: cmake -E env [options...] [--] <command> [<args>...] The options it accepts include `NAME=VALUE` assignments and `--unset=NAME`. Without an explicit `--` separator, CMake has to decide where its own options end and the child command begins, and parses tokens greedily as options until it sees one that doesn't look like one. That heuristic breaks as soon as the "command" we want to run looks option-shaped, e.g. starts with `-`, contains `=`, or is a path/generator-expression that CMake can't unambiguously classify. Symptoms range from "the variable assignment gets dropped" to "the wrong binary gets executed" to outright parse errors, depending on CMake version. The `--` terminator removes the ambiguity: everything before `--` is `env`'s own options, everything after is the child command and its arguments. Support for `--` in `cmake -E env` was added in CMake 3.24, which is why this commit does three things together: 1. Bump `cmake_minimum_required` to 3.24 in `CMakeLists.txt`, `benchmark/CMakeLists.txt`, and `Runtimes/Resync.cmake` so the new syntax is guaranteed to exist. 2. Insert `--` before the child command in every `cmake -E env` call site: - gyb invocations (`Runtimes/{Core,Overlay,Supplemental}/cmake/modules/gyb.cmake`, `cmake/modules/SwiftHandleGybSources.cmake`, `cmake/modules/AddSwift.cmake`) - libdispatch's install step (`cmake/modules/Libdispatch.cmake`) - LTO archiver wrappers (`cmake/modules/UnixCompileRules.cmake`) - lit test driver (`test/CMakeLists.txt`) The lit driver case is the most fragile pre-fix: `${SWIFT_LIT_ENVIRONMENT}` is an arbitrary list of `KEY=VAL` pairs assembled at configure time, and the very next argument is a generator-expression resolving to the Python binary path. Without `--`, CMake had to guess where the env list ended; with `--`, the boundary is explicit. 3. Clean up two things the bump made stale: - `CMakeLists.txt`'s `if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.22")` guard around `cmake_host_system_information(... DISTRIB_PRETTY_NAME)` is now unconditionally true, so the guard is dropped and the call made unconditional. - `benchmark/README.md`'s standalone-CMake instructions still told readers to install cmake 3.19.6 or higher, which would now fail at configure time in `benchmark/CMakeLists.txt`; updated to 3.24. Still-live version guards are deliberately left alone: the 3.26 check for ARM64 assembly on Windows in `CMakeLists.txt`, and the 3.31 checks under `Runtimes/`.