Sema: Fix UB in `NonisolatedNonsendingByDefault` migration diagnosis
The diagnostic can outlive the locally constructed attribute, which was
passed by pointer, if there is an active `DiagnosticTransaction`.
(cherry picked from commit f4e49d5a0a4cd0c8e7f83e447bc156a4e7f1a742)