swift

ee24ce04 - Sema: Targeted fix for bad interaction between resilience checks and -enable-testing

Sema: Targeted fix for bad interaction between resilience checks and -enable-testing The -enable-testing flag makes ValueDecl::getEffectiveAccess() say that internal declarations are public. This would lead us to emit spurious diagnostics if a default argument of an internal function referenced a private symbol, for example, which is something we actually want to allow. This is a second revision of the patch -- instead of changing getEffectiveAccess() to take an extra parameter, this changes getFormalAccessScope() instead. Fixes <rdar://problem/32592973>.