next.js

0b1209ed - Revert "Revert "Use turbo-tasks-malloc on all platforms" (#66884)", fix aarch64 compilation in CI (#66885)

Revert "Revert "Use turbo-tasks-malloc on all platforms" (#66884)", fix aarch64 compilation in CI (#66885) We either need GCC >= 4.9 or we need to link with libatomic: https://github.com/microsoft/mimalloc/issues/443 Unfortunately, manylinux2014-cross ships with GCC 4.8.5: https://github.com/rust-cross/manylinux-cross/blob/main/manylinux2014/aarch64/Dockerfile#L71 We already appear to override the compiler toolchain in CI for x86_64 to use clang (which is why mimalloc works there), so let's go ahead and do that here too. This at least means we're using the same compiler across both architectures. I'm leaving the aarch64-musl codepath the same (using gcc) because (1) we don't use mimalloc there yet and (2) it's a bit harder for me to test as thoroughly. # Testing ## Local Compilation Run bash inside the docker image (I also had to install rosetta2 inside my Linux VM, as this is an x86_64 image used for cross-compilation to aarch64): ``` podman run --platform=linux/amd64 -t -i ghcr.io/napi-rs/napi-rs/nodejs-rust:stable-2023-09-17-aarch64 bash -l ``` ``` git clone https://github.com/vercel/next.js.git --filter=blob:none --branch canary --single-branch cd next.js git checkout 6ae9828cceed9a405ce0205c6a4df43f6c68e417 ``` Run the build locally: ``` apt update && apt install -y pkg-config xz-utils dav1d libdav1d-dev && export JEMALLOC_SYS_WITH_LG_PAGE=16 && rustup show && rustup target add aarch64-unknown-linux-gnu && npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}" && export CC_aarch64_unknown_linux_gnu=/usr/bin/clang && export CFLAGS_aarch64_unknown_linux_gnu="--target=aarch64-unknown-linux-gnu --sysroot=/usr/aarch64-unknown-linux-gnu" && cd packages/next-swc && npm run build-native-release -- --target aarch64-unknown-linux-gnu && llvm-strip -x native/next-swc.*.node && objdump -T native/next-swc.*.node | grep GLIBC_ ``` Sanity check that the result is an aarch64 binary ``` $ file native/next-swc.linux-arm64-gnu.node native/next-swc.linux-arm64-gnu.node: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, not stripped ``` ## Verifying the binary works Copy the next-swc binary into a copy of shadcn-ui I have sitting around: ``` podman cp 4e8f61b17965:/next.js/packages/next-swc/native/next-swc.linux-arm64-gnu.node ~/ui/node_modules/.pnpm/file+..+nextpack+tarballs+next-swc.tar/node_modules/@next/swc/native/next-swc.linux-arm64-gnu.node ``` and then try running the dev server and loading pages from it in the browser: ``` pnpm --filter=www dev --turbo ``` ## In CI https://github.com/vercel/next.js/actions/runs/9523143080/job/26254016137