next.js
3141f076 - Disable `colormin` feature from `cssnano` (#53393)

Commit
1 year ago
Disable `colormin` feature from `cssnano` (#53393) cssnano by default tries to convert `rgb` colors to an `hsla` color when the `hsla` color is shorter for minification purposes. The issue with this is that the colors aren't the same and we are losing data when converting to `hsla`. Input: ```css html { background-color: rgb(143 101 98 / 43%); } ``` Output: ```css html { background-color: hsla(4, 19%, 47%, .43); } ``` (I pretty printed it to make the diff a bit nicer). If we would convert this `hsla` color back to `rgb` syntax, then it results in: ```css html { background-color: rgb(143 100 97 / 43%); } ``` Comparing the original value with the last value, then you can see the difference: ```diff html { - background-color: rgb(143 101 98 / 43%); + background-color: rgb(143 100 97 / 43%); /* ^ ^ */ } ``` To solve this issue, we can just disable the `colormin` minification of `cssnano` entirely. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
Author
Parents
Loading