next.js
4562ce8c - test: drop skipDeployment where another gate already excludes deploy (#99194)

Commit
32 days ago
test: drop skipDeployment where another gate already excludes deploy (#99194) ## Summary Eleven suites carry `skipDeployment` on top of a condition that already keeps them out of deploy mode, so the option is dead weight. Each was run in deploy on the #99184–#99187 batches with the exclusion removed, and each reported green in roughly **2.4s** — the signature of a suite that registered no tests, not one that deployed and passed. So removing the option is behaviour-neutral. It also removes the `it.only` that `skipDeployment` registers, which focuses the whole *file* and can silently skip unrelated suites beside it. ## Why each genuinely cannot run against a deployment | suite | blocker | |---|---| | `app-action-export`, `invalid-custom-routes`, `invalid-middleware-matchers` | mutate fixture files after setup (`patchFile` / `deleteFile`), then rebuild | | `instant-validation-build`, `externals-pages-bundle` | call `next.build()` and read the local build output | | `telemetry/config`, `telemetry/page-features`, `telemetry/telemetry` | telemetry events are emitted by the local CLI process | | `cpu-profiling-build` | reads `.next-profiles` off disk, and already returns early on `isNextDeploy` | | `back-button-download-bug`, `next-test` | the whole suite is `describe.skip`, for reasons unrelated to deployment | ## Not in this PR From the same set of 19, four look like the *gating* is wrong rather than the exclusion being correct, and they need their own change plus a deploy run: - `typescript-version-warning` and `typescript-version-no-warning` use only `next.start` and `next.cliOutput`, and assert on build output that deploy does provide. They are excluded by an explicit `if (isNextDeploy || isNextDev)` that reads as caution rather than a finding. - `url-imports` uses only `render` and `browser`. Its `describe.skip` is Turbopack-specific and legitimate, so it needs the webpack deploy job rather than a code change. - `webpack-loader-parse-error` is already being enabled in #98850. And `invalid-module-document`, `undefined-webpack-config`, `typegen-error-diagnostic`, `turbopack-emit-collect` need the deferred-deployment-lifecycle conversion or a closer read first. ## Verification Deploy-mode runs on #99184–#99187 (Turbopack). Confirmed per file that canary carries one `skipDeployment` and this branch carries none, with no other change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Author
Parents
Loading