next.js
68de4c03 - fix revalidation/refresh behavior with parallel routes (#63607)

Commit
2 years ago
fix revalidation/refresh behavior with parallel routes (#63607) `applyRouterStatePatchToTree` had been refactored to support the case of not skipping the `__DEFAULT__` segment, so that `router.refresh` or revalidating in a server action wouldn't break the router. (More details in this #59585) This was a stop-gap and not an ideal solution, as this behavior means `router.refresh()` would effectively behave like reloading the page, where "stale" segments (ones that went from `__PAGE__` -> `__DEFAULT__`) would disappear. This PR reverts that handling. The next PR in this stack (#63608) adds handling to refresh "stale" segments as well. Note: We expect the test case that was added in #59585 to fail here, but it is re-enabled in the next PR in the stack. Note 2: #63608 was accidentally merged into this PR, despite being a separate entry in the stack. As such, I've copied the issues from that PR into this one so they can be linked. See the notes from that PR for the refresh fix details. Fixes #60815 Fixes #60950 Fixes #51711 Fixes #51714 Fixes #58715 Fixes #60948 Fixes #62213 Fixes #61341 Closes [NEXT-1845](https://linear.app/vercel/issue/NEXT-1845) Closes [NEXT-2030](https://linear.app/vercel/issue/NEXT-2030) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-2903
Author
Parents
Loading