next.js
87a1c18e - test: preserve static params during Cache Components migration (#98209)

Commit
2 days ago
test: preserve static params during Cache Components migration (#98209) ## Summary Adds an agent eval covering migration of the legacy on-demand ISR pattern: `force-static`, `revalidate`, and an empty `generateStaticParams` result. The assertions require the agent to enable Cache Components, preserve the `generateStaticParams` export, and replace its empty result with at least one parameter instead of deleting the function. The fixture also runs the Cache Components adoption skill with the established 30-minute timeout. Updates the Cache Components migration guide to link each legacy route segment config to its migration instructions. The `generateStaticParams` section now explains that removing the export opts a dynamic route out of ISR and links to the ISR with Cache Components guide. ## Eval results ### Before the guide change | Treatment | Result | Duration | Behavior | | --- | --- | ---: | --- | | Baseline | Passed (1/1) | 482.9s | Preserved `generateStaticParams` and returned a real seed. | | Bundled docs / AGENTS.md | Failed (0/1) | 444.7s | Deleted `generateStaticParams`, incorrectly treating omission as equivalent to returning an empty array. | | Cache Components skill | Passed (1/1) | 527.6s | Preserved `generateStaticParams` and returned a real seed. | The failed treatment was classified as a model failure. It read the bundled migration guide but concluded that deleting `generateStaticParams` preserved the defer-all-paths-to-runtime behavior. The eval catches that loss of on-demand ISR semantics. The full run used the identical fixture immediately before its numeric identifier was changed from `agent-044` to the final `agent-054` name. The fixture and assertions were unchanged. ### After the guide change | Treatment | Result | Duration | Behavior | | --- | --- | ---: | --- | | Baseline | Passed (1/1) | 739.5s | Preserved `generateStaticParams`, returned `FEATURED_EVENT_SLUG`, and compared the migrated route with the original behavior. | | Bundled docs / AGENTS.md | Passed (1/1) | 393.2s | Read the revised migration and ISR guides, preserved `generateStaticParams`, and returned `FEATURED_EVENT_SLUG`. | | Cache Components skill | Passed (1/1) | 547.3s | Preserved `generateStaticParams`, returned `FEATURED_EVENT_SLUG`, and verified the build and representative routes in development. | In the first controlled pair, the bundled-docs treatment changed from failing to passing. Its final migration kept the route eligible for ISR, preserved the 60-second revalidation behavior with `use cache` and `cacheLife`, and produced a passing build. ### Additional variance check The bundled-docs treatment was run once more against each guide version: | Guide version | First sample | Second sample | Observed result | | --- | --- | --- | --- | | Before this change | Failed (444.7s) | Passed (455.6s) | 1/2 passed | | After this change | Passed (393.2s) | Passed (425.2s) | 2/2 passed | The second pre-change sample shows that the previous wording could still lead the agent to the correct migration. The revised wording passed both observed samples, suggesting that the explicit ISR consequence improves reliability. Two samples per version are not enough to claim a stable pass rate. ## Verification - `pnpm --filter=next build` - `pnpm eval agent-054-cache-components-empty-static-params --dry` - `pnpm eval agent-054-cache-components-empty-static-params` <!-- NEXT_JS_LLM -->
Author
Parents
Loading