next.js
a46c5afa - fix: use `fs.existsSync` to avoid race condition (#56387)

Commit
2 years ago
fix: use `fs.existsSync` to avoid race condition (#56387) Using `await fs.access` has couple of downsides. It creates unnecessary async contexts where async scope can be removed. Also, it creates the possibility of race conditions such as `Time-of-Check to Time-of-Use`. It would be nice if someone can benchmark this. I'm rooting for a performance improvement. Some updates from Node.js land: - There is an open pull request to add V8 Fast API to `existsSync` method - https://github.com/nodejs/node/pull/49893 - Non-existing `existsSync` executions became 30% faster - https://github.com/nodejs/node/pull/49593 Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Author
Parents
Loading