next.js
ae2c750d - [dev-tools] Robust shortcut detection (#81756)

Commit
282 days ago
[dev-tools] Robust shortcut detection (#81756) This PR resolves NEXT-4610 by using `e.code` over `e.key` in both storing and detecting keyboard shortcuts. Consider this problematic keybind: Alt + L If we capture `e.key` here then it will correspond to a glyph (¬) because pressing Alt + L creates this character. While `e.code` will give us `KeyL` as the value which we also later use in `useShortcuts()` to match the keybind correctly without having to detect glyphs. --- After this PR: https://github.com/user-attachments/assets/222fc65f-7320-4487-b387-ea263acfe387
Author
Parents
Loading