next.js
bc7ce5d6 - Reland: Fix false-positive `"use cache"` misplacement error (#79222)

Commit
1 year ago
Reland: Fix false-positive `"use cache"` misplacement error (#79222) _Relanding #79151, now ignoring TS AST nodes when checking whether all exported module items are async functions._ This fixes an error where we incorrectly showed the following compiler error when using Turbopack: ```sh Ecmascript file had an error > 1 | 'use cache' | ^^^^^^^^^^^ 2 | 3 | import { useStuff } from './client-module' 4 | The "use cache" directive must be at the top of the file. ``` The directive was regarded as not being at the top of the file, because the React transform (`EcmascriptInputTransform::React`) injects a variable declaration for React Refresh (e.g. `var _s = __turbopack_context__.k.signature`) at the top of the file, before the `"use cache"` directive. We can fix this by ensuring that the server action transform (should really be called "server _function_ transform") runs first. As a consequence, the transform now needs to be able to parse JSX AST nodes, which was already explicitly implemented. closes NAR-130 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
Author
Parents
Loading