next.js
c2085df2 - [dev-overlay] change dev indicator position by next config option (#76077)

Commit
1 year ago
[dev-overlay] change dev indicator position by next config option (#76077) ### What? This PR uses the `devIndicators.position` option to set the position of the dev indicator. The default option is changed from `"bottom-right"` to `"bottom-left"` to sync the previous dev indicator behavior, but have covered backward compatibility for the default position of old overlay's build activity indicator. ### Success Criteria - [x] Does setting `buildActivityPosition` correctly set the dev indicator position? - [x] Does setting the `position` correctly set the dev indicator position? - [x] Does it default to `"bottom-left"`? - [x] Does the dev indicator popover display properly based on the `position`? Backwards Compatible: > Are there any breaking changes? - [x] Is the position `"bottom-right"` on the old overlay if the user hasn't set the `position`? - [x] Is the position `"bottom-right"` on the old overlay if the user hasn't set the `buildActivityPosition`? - [x] Does the position follow the `position` option? - [x] Does the position follow the `buildActivityPosition` option? https://github.com/user-attachments/assets/a5dba705-1b9d-4470-80e6-1952b22c2f46 Closes NDX-838
Author
Parents
Loading