turbo
d8966ae5 - Fixes `new URL()` during SSR (#3021)

Commit
2 years ago
Fixes `new URL()` during SSR (#3021) A follow up to #2944, which incorrectly rewrote the `new URL("…", import.meta.url)` to `new URL("…", location.origin)` during server rendering (which obviously doesn't have a `location` object). This PR accomplishes 2 things: - Splits dev server address binding from setting up the handler function - This is necessary so that we can determine the bound server address during devs retry attempts. - Propagates the server address through the `ExecutionEnvironment` to the `UrlAssetReference` I chose to pipe the server address through the `ExecutionEnvironment` instead of the `EnvironmentIntention`, because I don't fully understand the differences between them. It seems like we want it in the intention for the types of rendering, but a server address is really tied to the node process, so I don't know. Fixes WEB-318
Author
Parents
Loading