etl
Add Devcontainer configurations
#1093
Merged
Overview
Commits
7
Changes
View On GitHub

Add Devcontainer configurations #1093

jwellbelove merged 7 commits into ETLCPP:development from wsciaroni:add-devcontainers
wsciaroni
wsciaroni15 days ago

This PR introduces .devcontainer.json files for a range of compiler versions (clang7-20 and gcc9-15).

This enhancement provides a consistent and isolated development environment for contributors. By using these configurations, developers can easily spin up pre-configured environments with the specified compilers, and their dependencies.

This will help to:

  • Ensure consistent build environments across different machines.
  • Simplify the setup process for new contributors when tracking compiler version specific issues.
  • Potentially reduce "it works on my machine" issues.

No code changes to the library itself are included in this PR.

wsciaroni Add clang devcontainers
2824f212
wsciaroni Add gcc devcontainers
f12159be
jwellbelove jwellbelove changed the base branch from master to development 12 days ago
jwellbelove Merge branch 'development' into add-devcontainers
0da9298c
rolandreichweinbmw
rolandreichweinbmw commented on 2025-05-14
Conversation is marked as resolved
Show resolved
.devcontainer/context/reinstall-cmake.sh
1#!/usr/bin/env bash
2#-------------------------------------------------------------------------------------------------------------
3# Copyright (c) Microsoft Corporation. All rights reserved.
4
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
rolandreichweinbmw11 days ago

Maybe just refer to the LICENSE file?

wsciaroni11 days ago

Ah, this was left by mistake. This license no longer applies as I have rewritten the entire file. That license was automatically added by VSCode.

wsciaroni10 days ago

Removed

wsciaroni Remove comment
8262510e
wsciaroni wsciaroni marked this pull request as ready for review 10 days ago
wsciaroni Merge branch 'development' into add-devcontainers
1a2a8005
wsciaroni Transition to bullseye variants of clang image to build
e860a2e7
rolandreichweinbmw
rolandreichweinbmw commented on 2025-05-16
Conversation is marked as resolved
Show resolved
.devcontainer/clang18/devcontainer.json
5 "build": {
6 "dockerfile": "../Dockerfile",
7 "args": {
8
 "BASE_IMAGE_NAME": "silkeh/clang:18-bullseye"
rolandreichweinbmw9 days ago

As far as I can see, devcontainers uses Debian 11 "bullseye" by default? Why not using "bookworm" (Debian 12) instead, for the newer clang versions?

(With Debian 13 being expected to be released soon).

wsciaroni9 days ago

I agree with your assessment, but when I use the default, the c++17 and newer builds fail (see #1091 for the error those images cause). When I was explicit with the version, I was able to build successfully.

This applies to the clang 18, 19, and 20 images.

wsciaroni Merge branch 'development' into add-devcontainers
dfdf7885
jwellbelove jwellbelove merged 21e5c2a6 into development 3 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum