julia
RFC: Create SecretBuffer and use it to help keep LibGit2's secrets
#27565
Merged
Overview
Commits
19
Changes
View On GitHub

RFC: Create SecretBuffer and use it to help keep LibGit2's secrets #27565

Keno merged 19 commits into master from mb+cv/secretbuffer
mbauman
ararslan ararslan requested a review from omus omus 8 years ago
ararslan ararslan added libgit2
ararslan ararslan added security
Keno Keno added this to the 0.7 milestone 8 years ago
omus
omus commented on 2018-06-14
omus
omus
vtjnash
vtjnash commented on 2018-06-14
vtjnash
vtjnash commented on 2018-06-14
omus
omus commented on 2018-06-14
omus
omus commented on 2018-06-14
mbauman
mbauman
Keno
staticfloat
staticfloat approved these changes on 2018-06-16
chethega
chethega commented on 2018-06-18
Keno
stevengj
stevengj
stevengj commented on 2018-06-20
iblislin
martinholters
Keno Keno removed this from to the 0.7 milestone 8 years ago
Keno Keno added this to the 0.7-beta milestone 8 years ago
omus Create type SecureString
41d87d58
omus Switch `GitCredential` equality to use `==`
8abc616f
mbauman Rename to SecretBuffer
16e65239
mbauman Rename file to reflect new name
e35a6353
mbauman Updates from review
cafe8505
omus Add SecretBuffer testset
bcc0a7b0
mbauman Add tests for initializers and fixup initializers
cf0a72ab
mbauman Fixup Cstring conversions
4aed3973
mbauman Qualify shred! in OldPkg
e223778b
mbauman Use constant time algorithm for ==(::SecureBuffer...)
94d2ebf7
mbauman Document `SecretBuffer(::AbstractString)`
dff0faab
mbauman Add warning about storing passwords in URLs to git_url
34c62716
mbauman Warn if not `shred!`ed before hitting finalizer
3e8960fc
mbauman mbauman force pushed from bba15138 to 3e8960fc 8 years ago
mbauman Detangle Base.prompt and Base.getpass
a5b1baad
mbauman Fixup `SecretBuffer!` docstrong from review
9ffda789
mbauman
stevengj
stevengj commented on 2018-06-21
stevengj
stevengj commented on 2018-06-21
stevengj
stevengj commented on 2018-06-21
stevengj
mbauman Add a space after `:` in prompts
5836427f
omus
mbauman
stevengj
stevengj commented on 2018-06-21
mbauman mbauman force pushed from 06457719 to c9b9cb88 8 years ago
omus
mbauman mbauman force pushed from c9b9cb88 to 23589011 8 years ago
mbauman mbauman force pushed from 23589011 to 9ab9f63f 8 years ago
mbauman Have `shred!(f, x)` return what `f(x)` returns
3c132302
mbauman Shred! creds used in Pkg
a927bbb1
mbauman remove redundant secure
5a50d9bb
mbauman mbauman force pushed from 9ab9f63f to 5a50d9bb 8 years ago
mbauman
Keno Keno merged 160fc7d8 into master 8 years ago
StefanKarpinski StefanKarpinski deleted the mb+cv/secretbuffer branch 8 years ago
ararslan
ararslan
ararslan commented on 2018-06-26

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
libgit2 security
Milestone
0.7-beta
Terms Of Use Privacy Policy Refund Policy Impressum