Add 2-arg versions of findmax/min, argmax/min #35316
StefanKarpinski
merged
29 commits into
JuliaLang:master
from
cmcaine:argmax-2-arg-harder
tkf
commented
on 2020-03-31
tkf
commented
on 2020-03-31
tkf
commented
on 2020-04-01
tkf
commented
on 2020-04-01
stevengj
commented
on 2020-04-11
vtjnash
commented
on 2020-10-29
tkf
commented
on 2020-11-24
andyferris
commented
on 2020-12-01
cmcaine
commented
on 2020-12-06
nalimilan
commented
on 2020-12-01
JeffBezanson
approved these changes
on 2020-12-17
Rename unexported isgreater in reduceddim
a928f4a4
Add isgreater
b2f11117
Add 2-arg versions of findmax/min, argmax/min
8767109c
Clarify description in NEWS.md
72c459d5
More doctest examples for argmin/max
1eb223b7
Clarify `isgreater` docstring
fc0dbab0
Update `isgreater` from review
9231741c
Simplify _is_reflexive and rename _is_reflexive_eq
4a851795
unexport isgreater
31a38a04
Use 2-arg findmax/min for findmax/min(a)
6cc600ec
Fix doctest
4c6923a5
Add example showing that first value wins
7c7cfbec
Fix more doctests
83569860
omit unnecessary let
8061ce83
define isgreater to be compatible with min
96433cfe
Fix doctests
91a825fd
typo
51c1d07f
Use pairs() in findmax(a)
f3dac8cb
Make findmax(A; dims) consistent with findmax(A) again
9ed02b21
Update docstrings
fae5eac5
Use convert in reducedim_init
3671795f
Support missing better in minimum(A; dims)
202edf79
rename is_poisoning -> isunordered and export
7aa7fdbb
Add tests for isunordered
c8f05bb8
Simplify findmin/findmax/argmin/argmax docstrings
abf1be4c
Add isunorded docstring and compat admonitions
925a365f
Add NEWS entry for isunordered
5e93247b
Correct compat admonition for isunordered
b2fe843f
Fix minimum(A; dims) when eltype(A) doesn't define typemin, but does …
62328100
Assignees
No one assigned
Labels
fold
Milestone
No milestone
Login to write a write a comment.
Login via GitHub