julia
recommend explicit `using Foo: Foo, ...` in package code (was: "using considered harmful")
#42080
Merged

recommend explicit `using Foo: Foo, ...` in package code (was: "using considered harmful") #42080

IanButterworth merged 13 commits into master from kc/warn_using
KristofferC
KristofferC warn against `using Foo` in package code
c2e519be
KristofferC KristofferC added docs
KristofferC KristofferC requested a review from ararslan ararslan 4 years ago
DilumAluthge
DilumAluthge approved these changes on 2021-09-01
DilumAluthge DilumAluthge added backport 1.6
DilumAluthge DilumAluthge added backport 1.7
ararslan
ararslan commented on 2021-09-01
mbauman
ararslan
DilumAluthge
ararslan
tkf
jlapeyre
domluna
tkf
johnnychen94
timholy
KristofferC
KristofferC
timholy
KristofferC
tkf
KristofferC KristofferC removed backport 1.6
KristofferC KristofferC removed backport 1.7
KristofferC
DilumAluthge
DilumAluthge
mbauman
mbauman
tkf
KristofferC
mbauman
tkf
mbauman
tkf
mbauman
tkf
KristofferC
jakobnissen
DilumAluthge
tkf
KristofferC
KristofferC
jakobnissen
KristofferC
tkf
KristofferC
DilumAluthge
KristofferC
cjdoris
rikhuijzer
KristofferC
rikhuijzer
LilithHafner
LilithHafner dismissed these changes on 2023-09-28
LilithHafner
palday
LilithHafner
palday
mbauman
ararslan
ararslan dismissed these changes on 2023-09-28
ararslan
adienes
ararslan
adienes
KristofferC
KristofferC
ararslan
cscherrer
brenhinkeller
IanButterworth
PallHaraldsson
LilithHafner
LilithHafner
ararslan
LilithHafner LilithHafner requested a review from LilithHafner LilithHafner 2 years ago
LilithHafner LilithHafner dismissed their stale review 2 years ago
Looking at cited examples in the package ecosystem, I don't think this is a significant problem
LilithHafner
ToucheSir
LilithHafner
jlapeyre
palday
mbauman
palday
mbauman
cscherrer
mbauman
brenhinkeller
cscherrer
mbauman
nsajko
ararslan
mbauman
mbauman
palday
LilithHafner
LilithHafner
ToucheSir
mbauman
LilithHafner
brenhinkeller
adienes
mbauman
CameronBieganek
jmichel7
KristofferC
MasonProtter
CameronBieganek
MasonProtter
ericphanson
PetrKryslUCSD
KristofferC
ararslan
mbauman
KristofferC
palday
LilithHafner LilithHafner added triage
KristofferC
MasonProtter
DilumAluthge Merge branch 'master' into kc/warn_using
f8a4c541
MasonProtter Add guidance for using qualified names in packages (#53428)
5a497c8c
DilumAluthge
DilumAluthge Merge branch 'master' into kc/warn_using
eb9c6681
DilumAluthge DilumAluthge added packages
DilumAluthge DilumAluthge added modules
mbauman
mbauman commented on 2024-06-04
mbauman
mbauman commented on 2024-06-04
mbauman Unify some of the language from #53428
aa0ce073
mbauman
mbauman mbauman changed the title recommend against `using Foo` in package code (or "using considered harmful") recommend explicit `using Foo: Foo, ...` in package code (was: "using considered harmful") 1 year ago
fredrikekre
LilithHafner
LilithHafner approved these changes on 2024-06-04
LilithHafner
mbauman mbauman requested a review from ararslan ararslan 1 year ago
fredrikekre
fredrikekre approved these changes on 2024-06-04
KristofferC make shorter
ca82f8b0
KristofferC KristofferC dismissed their stale review 1 year ago
updated
ararslan
ararslan dismissed these changes on 2024-06-06
LilithHafner
KristofferC Update base/docs/basedocs.jl
d99b8d11
KristofferC Update doc/src/manual/modules.md
990cd5c3
ararslan
ararslan commented on 2024-06-07
DilumAluthge Merge branch 'master' into kc/warn_using
9cdfc278
MasonProtter
IanButterworth Update doc/src/manual/modules.md
cd7e39b2
IanButterworth Merge branch 'master' into kc/warn_using
8d7a1834
IanButterworth IanButterworth added merge me
IanButterworth IanButterworth requested a review from ararslan ararslan 1 year ago
IanButterworth
IanButterworth IanButterworth added backport 1.10
IanButterworth IanButterworth added backport 1.11
nsajko
nsajko approved these changes on 2024-10-24
nsajko
nsajko approved these changes on 2024-10-24
IanButterworth Apply suggestions from code review
402d284b
MasonProtter
LilithHafner LilithHafner dismissed their stale review 1 year ago
Suggested changes were made
DilumAluthge Merge branch 'master' into kc/warn_using
8b4ae860
IanButterworth IanButterworth removed triage
IanButterworth IanButterworth merged ee09ae70 into master 1 year ago
IanButterworth IanButterworth deleted the kc/warn_using branch 1 year ago
DilumAluthge DilumAluthge removed merge me
KristofferC KristofferC removed backport 1.10
KristofferC KristofferC removed backport 1.11

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone