julia
broadcast: align `ndims` implementation with intent behind code
#56999

Merged

broadcast: align `ndims` implementation with intent behind code #56999

N5N3 merged 5 commits into JuliaLang:master from nsajko:ndims_broadcasted

nsajko added arrays

nsajko added bugfix

nsajko added broadcast

nsajko commented on 2025-01-08

nsajko force pushed from f179208b to f53d3a29 1 year ago

nsajko added backport 1.10

nsajko added backport 1.11

nsajko requested a review from

N5N3 1 year ago

ararslan commented on 2025-01-09

jishnub commented on 2025-01-09

nsajko force pushed from f5afe585 to 5f43d7d1 1 year ago

nsajko commented on 2025-01-09

broadcast: align `ndims` implementation with intent behind code

eb66b6d7

add comments in method body

eaac59c5

use an explicit error check instead of the obscure type application

0c7165d3

use dispatch instead of explicit subtyping checks

165a4136

get rid of the negative dimension count error check

e5b8d161

nsajko force pushed from 827581d7 to e5b8d161 1 year ago

N5N3 merged d3964b60 into master 1 year ago

nsajko deleted the ndims_broadcasted branch 1 year ago

KristofferC removed backport 1.11

Reviewers

ararslan

jishnub

N5N3

Assignees

No one assigned

Labels

arrays bugfix broadcast backport 1.10

Milestone

No milestone