pytorch-lightning
Fix zero-grad behavior when entering the validation loop
#18710
Merged
Overview
Commits
20
Changes
View On GitHub

Fix zero-grad behavior when entering the validation loop #18710

awaelchli merged 20 commits into master from bugfix/val-loop-zero-grad
awaelchli
awaelchli set to none
297ba71a
github-actions github-actions added pl
awaelchli awaelchli added performance
awaelchli awaelchli added this to the v1.9.x milestone 2 years ago
awaelchli repro
83f41536
awaelchli move the zero grad call
64631945
awaelchli awaelchli changed the title Set grads to None in PyTorch < 2.0 at validation start Set grads to None only once at the beginning of `Trainer.validate/test/predict` 2 years ago
awaelchli update tests
ea7ee7e7
awaelchli x
55cecc16
awaelchli test
81411435
carmocca
carmocca commented on 2023-10-04
awaelchli add test
4ac0ad32
awaelchli add hook
660af789
awaelchli update tests
65ddfb3e
awaelchli changelog
ee6dd166
awaelchli awaelchli changed the title Set grads to None only once at the beginning of `Trainer.validate/test/predict` Fix zero-grad behavior when enterint the validation loop 2 years ago
awaelchli awaelchli changed the title Fix zero-grad behavior when enterint the validation loop Fix zero-grad behavior when entering the validation loop 2 years ago
awaelchli awaelchli added bug
awaelchli awaelchli added hooks
awaelchli awaelchli added trainer: validate
awaelchli awaelchli added loops
awaelchli condition on pytorch 2.0
a15fcda4
awaelchli reset
f602b38c
awaelchli condition on torch 2.0
ab435761
awaelchli make tests a bit ugly
333e793e
awaelchli
awaelchli commented on 2023-10-05
awaelchli awaelchli marked this pull request as ready for review 2 years ago
awaelchli awaelchli requested a review from williamFalcon williamFalcon 2 years ago
awaelchli awaelchli requested a review from tchaton tchaton 2 years ago
awaelchli awaelchli requested a review from justusschock justusschock 2 years ago
awaelchli awaelchli requested a review from Borda Borda 2 years ago
github-actions
carmocca
carmocca commented on 2023-10-05
awaelchli update test
e84a1192
awaelchli fix
28890bf5
codecov
carmocca
carmocca approved these changes on 2023-10-07
Borda
Borda approved these changes on 2023-10-09
mergify mergify added ready to be merged
awaelchli Update src/lightning/pytorch/core/hooks.py
375aa1cd
awaelchli Update src/lightning/pytorch/trainer/trainer.py
b3290190
pre-commit-ci[bot] [pre-commit.ci] auto fixes from pre-commit.com hooks
dc06b15c
awaelchli Merge branch 'master' into bugfix/val-loop-zero-grad
20b72207
awaelchli awaelchli merged a26424e8 into master 2 years ago
awaelchli awaelchli deleted the bugfix/val-loop-zero-grad branch 2 years ago
awaelchli awaelchli removed this from to the v1.9.x milestone 2 years ago
awaelchli awaelchli added this to the 2.1 milestone 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
bug ready to be merged hooks loops trainer: validate performance pl
Milestone
2.1
Terms Of Use Privacy Policy Refund Policy Impressum