pytorch-lightning
Fix `save_hyperparameters` ignore precedence in subclasses
#21490

Merged

Fix `save_hyperparameters` ignore precedence in subclasses #21490

tchaton merged 11 commits into Lightning-AI:master from aditya0by0:bugfix/21488_save_hparams

fix test - iterate over args rather than character

518aa101

test for save_hparams across hierarchy

4e8a9841

aditya0by0 requested a review from

lantiga 221 days ago

aditya0by0 requested a review from

tchaton 221 days ago

aditya0by0 requested a review from

justusschock 221 days ago

aditya0by0 requested a review from

ethanwharris 221 days ago

github-actions added pl

aditya0by0 commented on 2026-01-15

deependujha requested changes on 2026-01-15

aditya0by0 force pushed from 6ec88656 to 4e8a9841 221 days ago

clear hparams before save hparms method is called

7ea064b2

update test hparams overrides by subclass

37c96495

aditya0by0 changed the title ~~Fix to make ignored hyperparameters persist across subclasses~~ Fix `save_hyperparameters` ignore precedence in subclasses 221 days ago

update change log

05c89cd6

update

3a1e511a

update

6f6bfe65

update

cbe3a05e

deependujha requested a review from

copilot-pull-request-reviewer 220 days ago

copilot-pull-request-reviewer commented on 2026-01-16

update

919e4118

deependujha approved these changes on 2026-01-16

deependujha commented on 2026-01-16

aditya0by0 force pushed from 2f671d0b to 919e4118 220 days ago

Merge branch 'master' into bugfix/21488_save_hparams

d1a47c49

empty commit

bf955679

tchaton approved these changes on 2026-01-28

tchaton merged 14a3902a into master 208 days ago

Reviewers

tchaton

deependujha

copilot-pull-request-reviewer

lantiga

justusschock

ethanwharris

Assignees

No one assigned

Labels

Milestone

No milestone

pytorch-lightning Fix `save_hyperparameters` ignore precedence in subclasses #21490 Merged

Fix `save_hyperparameters` ignore precedence in subclasses #21490

pytorch-lightning
Fix `save_hyperparameters` ignore precedence in subclasses
#21490

Merged