jax
Implement approx_tanh for ROCm using OCML tanh function
#614

Merged

Implement approx_tanh for ROCm using OCML tanh function #614

phambinhfin merged 4 commits into rocm-jaxlib-v0.8.0 from phambinh/approx-tanh-rocm-impl

Implement approx_tanh for ROCm using OCML tanh function

2a923494

phambinhfin requested a review 125 days ago

phambinhfin requested a review from

xiaohuguo2023 125 days ago

Use fast_tanhf instead of slow __ocml_tanh_f32 for ROCm approx_tanh

6deef153

xiaohuguo2023 requested changes on 2026-01-20

Address review comments for approx_tanh ROCm implementation

c55c465e

phambinhfin force pushed from 6269be02 to c55c465e 125 days ago

Add f64 support to approx_tanh for ROCm

d217d1e4

phambinhfin force pushed from eb936bcd to d217d1e4 125 days ago

phambinhfin added open-upstream

phambinhfin added cherry-pick-candidate

gulsumgudukbay approved these changes on 2026-01-20

xiaohuguo2023 approved these changes on 2026-01-20

phambinhfin merged 32a91b36 into rocm-jaxlib-v0.8.0 124 days ago

Reviewers

xiaohuguo2023

gulsumgudukbay

Arech8

Assignees

No one assigned

Labels

open-upstream cherry-pick-candidate

Milestone

No milestone