react-spectrum
5ad8f6e2 - TagGroup followup items (#2947)

Commit
3 years ago
TagGroup followup items (#2947) * initial TagGroup commit * lint * another lint * temp skip tests * slotting tags * tag group styling * update taggroup icon story * undo bad pull from main * linting * add roles. update tests * pass custom props to indiv tag * update grid version * add missing param * use padding-inline-start for styling * onRemove button styling, typing, add story * remove useTag tests, styling * merge props together * tag focus and keyboard nav * clear button role and css * move tag ref declarations out of useTag * linting * more linting * add rowheader role to tags * typo * remove cycleMode from GridKeyboardDelegate * consolidate tag roles * wip keyboard nav * fix refs and props spreading and keyboard nav * add A TON of tests * prevent focus on remove button * skip disabled tags in keyboard nav * remove unused packages * add translations * remove extra aria label, unneeded intl files, and add labelId to props * some accessibility updates and general code feedback * change it.each tests to single tests * don't export spectrumtagprops * only export TagGroup * ensure tags are generated the same way * don't assign role if no children * add role conditional * minor css * add stories * set columnCount to 1, add forgotten keyboard nav logic * fix tests too accept wrapping * change tag ref logic * linting * Remove 'escape' from remove logic Co-authored-by: Robert Snow <rsnow@adobe.com> * remove unused css class; simplify PageUp/Down keyboard nav * fix keys in story * add remove keypress tests Co-authored-by: Jeff Luyau <luyau@adobe.com> Co-authored-by: Tiffany Lin <tiffanyl@adobe.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
Parents
Loading