react-spectrum
TagGroup followup items
#2947
Merged

TagGroup followup items #2947

LFDanLu merged 60 commits into main from taggroup-followup
tiffany-sy-lin
jluyau initial TagGroup commit
6e3130f1
jluyau lint
dbbe675f
jluyau another lint
f450b3bf
jluyau temp skip tests
9280b39b
Merge branch 'main' of github.com:adobe/react-spectrum into taggroup
4e51f884
slotting tags
291e782a
tiffany-sy-lin tag group styling
45975073
tiffany-sy-lin Merge branch 'main' of github.com:adobe/react-spectrum into taggroup
0d61c4c1
tiffany-sy-lin update taggroup icon story
2ffa9b69
tiffany-sy-lin undo bad pull from main
c2202544
tiffany-sy-lin linting
377a136a
Merge branch 'main' of github.com:adobe/react-spectrum into taggroup
5586040f
add roles. update tests
bf97d2c7
pass custom props to indiv tag
b4918eef
update grid version
d3a79ab4
add missing param
b8883fc8
tiffany-sy-lin Merge branch 'main' into taggroup
69d9ddf1
use padding-inline-start for styling
8dce23b5
Merge branch 'main' of github.com:adobe/react-spectrum into taggroup
fa23d87f
onRemove button styling, typing, add story
49c352a9
remove useTag tests, styling
356c1fb8
merge props together
6dba19f8
tag focus and keyboard nav
844d04ea
clear button role and css
cb23a228
move tag ref declarations out of useTag
dc2caa8a
linting
a35a6d8a
more linting
e163152e
add rowheader role to tags
7b31d69c
Merge branch 'main' of github.com:adobe/react-spectrum into taggroup
1da0b97c
typo
5337c3a2
remove cycleMode from GridKeyboardDelegate
eff5861d
consolidate tag roles
05be8092
Merge branch 'main' of github.com:adobe/react-spectrum into taggroup
8f00b1d1
wip keyboard nav
8f5219cf
fix refs and props spreading and keyboard nav
86fe9469
add A TON of tests
6e2e5329
prevent focus on remove button
9dac424c
skip disabled tags in keyboard nav
d32a5df2
remove unused packages
0cfd8c78
add translations
8c6370a0
remove extra aria label, unneeded intl files, and add labelId to props
b7ddd9f7
some accessibility updates and general code feedback
69aef006
Merge branch 'main' of github.com:adobe/react-spectrum into taggroup-…
d3ca4671
change it.each tests to single tests
75737d49
don't export spectrumtagprops
99b55efc
only export TagGroup
659cf9ee
ensure tags are generated the same way
bc48b142
don't assign role if no children
447d63e9
add role conditional
f4468f6a
snowystinger
snowystinger commented on 2022-03-12
tiffany-sy-lin
minor css
d1311794
adobe-bot
add stories
017a7068
LFDanLu
LFDanLu commented on 2022-04-02
tiffany-sy-lin
LFDanLu
LFDanLu requested changes on 2022-04-04
set columnCount to 1, add forgotten keyboard nav logic
0cf1d9cb
fix tests too accept wrapping
351b66ed
adobe-bot
change tag ref logic
bfe7d8f7
linting
3fcf89a8
adobe-bot
snowystinger
snowystinger commented on 2022-04-18
tiffany-sy-lin Remove 'escape' from remove logic
2f5036af
adobe-bot
remove unused css class; simplify PageUp/Down keyboard nav
5790d3d9
adobe-bot
tiffany-sy-lin tiffany-sy-lin requested a review from LFDanLu LFDanLu 3 years ago
tiffany-sy-lin tiffany-sy-lin requested a review from snowystinger snowystinger 3 years ago
LFDanLu
LFDanLu commented on 2022-04-19
fix keys in story
c8a91ddd
add remove keypress tests
7b815fa4
adobe-bot
snowystinger
snowystinger approved these changes on 2022-04-19
LFDanLu Merge branch 'main' into taggroup-followup
bbf7b733
adobe-bot
LFDanLu
LFDanLu approved these changes on 2022-04-19
LFDanLu LFDanLu merged 5ad8f6e2 into main 3 years ago
LFDanLu LFDanLu deleted the taggroup-followup branch 3 years ago
LFDanLu LFDanLu added needs testing
LFDanLu LFDanLu added TagGroup
dannify dannify added release
dannify dannify removed needs testing
dannify dannify removed release

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone