react-spectrum
ec00486f - Fix Infinite rendering in RAC ComboBox/Select with renderProps (#4520)

Commit
2 years ago
Fix Infinite rendering in RAC ComboBox/Select with renderProps (#4520) * only expose a subset of state to renderProps for combobox prevents infinite render loop * fix select infinite rendering * propagate data test id * fix dnd * fixing Tabs infinite rendering * getting rid of otherProps from useRenderProps due to uncertain dep array * filtering props inline where the types dont allow for id/aria labelling anyways * moving useRenderProps for dropIndicator into separate component allows us to still conditionally call the useRenderProps hook if isHidden is true or not * adding description to story * missed some extraneous filterDOMProps these call filterDOMProps in their hooks * fix lint * cleanup from cherrypicked commits
Author
Parents
Loading