react-spectrum
Fix Infinite rendering in RAC ComboBox/Select with renderProps
#4520
Merged

Fix Infinite rendering in RAC ComboBox/Select with renderProps #4520

LFDanLu merged 15 commits into main from infinite_render_combobox_rac_fix
LFDanLu
LFDanLu only expose a subset of state to renderProps for combobox
df8402ee
LFDanLu fix select infinite rendering
2d734a67
LFDanLu
LFDanLu commented on 2023-05-12
LFDanLu
LFDanLu commented on 2023-05-12
LFDanLu propagate data test id
fd6d3edf
LFDanLu
LFDanLu commented on 2023-05-13
LFDanLu fix dnd
58fc450e
rspbot
LFDanLu fixing Tabs infinite rendering
5fa95589
rspbot
LFDanLu getting rid of otherProps from useRenderProps due to uncertain dep array
0a8fad25
rspbot
LFDanLu filtering props inline where the types dont allow for id/aria labelli…
afcdd4e8
rspbot
LFDanLu Merge branch 'main' of github.com:adobe/react-spectrum into infinite_…
bebb9df9
LFDanLu LFDanLu marked this pull request as ready for review 2 years ago
LFDanLu
LFDanLu commented on 2023-05-16
LFDanLu
LFDanLu commented on 2023-05-16
rspbot
rspbot
LFDanLu
LFDanLu commented on 2023-05-16
LFDanLu LFDanLu added release
LFDanLu LFDanLu added ready for review
rspbot
snowystinger
snowystinger commented on 2023-05-16
rspbot
rspbot
LFDanLu moving useRenderProps for dropIndicator into separate component
474a4ce0
LFDanLu adding description to story
52eca146
LFDanLu missed some extraneous filterDOMProps
05c68d31
LFDanLu fix lint
fdee7e2a
LFDanLu LFDanLu force pushed from c5c2804a to fdee7e2a 2 years ago
rspbot
LFDanLu cleanup from cherrypicked commits
0fc5bcfe
LFDanLu Merge branch 'main' into infinite_render_combobox_rac_fix
500ea695
rspbot
rspbot
snowystinger
snowystinger approved these changes on 2023-05-17
ktabors
ktabors approved these changes on 2023-05-17
LFDanLu Merge branch 'main' into infinite_render_combobox_rac_fix
c7869e46
rspbot
rspbot
LFDanLu LFDanLu merged ec00486f into main 2 years ago
LFDanLu LFDanLu deleted the infinite_render_combobox_rac_fix branch 2 years ago
dannify dannify removed release
dannify dannify added release
dannify dannify removed release
dannify dannify removed ready for review

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone