Combobox mobile #1014
devongovett
merged
143 commits into
main
from
combobox_mobile
cleaning up comments and fixing keydown on readOnly combobox
df1e779b
fixing lint, tests, and adding buttons to combobox stories
23e92203
Adding check on thrown error message for combobox
25298549
spy on console.error in combobox test
2d1d7b23
addressing review comments
f674226a
adding keyUp after keyDown in combobox tests
ded943e5
initial progress
d863c401
fix lint
b9cad788
Merge branch 'main' into combobox_testing_followups
21a97b5e
disabling autocomplete on Combobox
ba380211
change setSelectedKey logic so it updates input text if key updates a…
fc5b00a5
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
8e44d868
removing width and adding flex to combobox textfield base
26644eea
add width 50px combobox story
a3fbd289
first stab at fixing combobox item hover vs keyboard focus style
5c57ffd2
Cleaning up Combobox focus modality logic
dfc7eb36
prevent combobox item focus on click and enforce tabindex=-1
6d03f642
using isFocusVisible instead of adding modality to useFocusVisible
41c9eeee
applying style props to combobox input if label is not defined
1d84a7fd
Adding additional tests and fixing lint
31756a06
adding test for selectedKey change when field is not focused
c2f3a005
Merge branch 'main' into combobox_testing_followups
b0fa7eac
fixing lint
5bb5176a
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
1f8139b0
Merge branch 'main' into combobox_testing_followups
98579f4b
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
4eeb33be
Merge branch 'main' into combobox_testing_followups
bf7545b1
figuring out focus behavior for textfield in tray
27c298d7
Fixing combobox tray focus behavior and logic for tray open/close
de9b5829
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
eda07308
Fixing combobox sizing in Firefox
43120d8d
adding small div story
ea979c41
filter shouldn't run if the length of the input value is length 0 pos…
d05cb91c
adding many sections story
a4695167
adding aria-expanded to combobox input and aria-labelledby to trigger…
cbfe4de6
adding useHover to combobox for hover styles
cdd00703
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
38f138d0
adding tests to catch empty space input filter case and aria-expanded…
3ce94d02
fixing tray input focus useeffect and adding test todo
c075694f
first stab at locking tray height in combobox
617e98b9
open combobox menu on input press if mobile
cfbc98eb
adding label to tray input
3ba05492
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
8ae0bf94
merging input props so keydown operations on combobox still work
413f4048
fixing Tray overflow and removing state tracker form tray height calc…
df57b1b3
preserving isFocused when focusing tray input
de8c53ae
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
b724cac4
providing offsetTop to virtualizer scrollToItem call
a045d719
Adding illustrated message as empty combobox tray view
9618ade1
Making tray height fixed for mobile combobox
efa3656b
adding popoverRef to Tray
05d68bc2
fixing lint
a6bbbd39
updating combobox button aria labeling
579b4432
Merge branch 'main' into combobox_testing_followups
02057867
Removing tray input specific logic from useCombobox
612dc223
Adjusting combobox empty view as per design
35e4c93b
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
f0a959c9
fixing test
ad4d3d47
Merge branch 'main' into combobox_testing_followups
80572e74
Making menu close when user deletes input field text except for menuT…
6f593940
Adding shouldSelectOnBlur prop
82d5d70c
fixing page up/down list navigation for combobox
573ba8e9
fixing page up and page down item nav for allowCustomValue combobox
b069d9f9
adding aria-label to combobox small div story
6cde7678
make arrow left and right clear focused key
c895dd06
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
7ed067e8
making listbox option be aria-selected if focused with virtual focus
f97a09d3
adding tests
83733cc6
clearing focused key on input change and removing autofocus behavior …
a2149020
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
fe97c3fe
keeping tray open when input text is deleted and typing comboboxTrayI…
f76d2c21
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
6807e9ed
Updating some dep arrays and utilizing useIsMobileDevice in combobox
2118daad
cleaning up package.json
c727f412
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
0f009443
allowing user to pass menuId to useCombobox
e5bf34d1
Clearing focused key on combobox menu close
96d7c5db
adding combobox mobile tests and fixing lint
c3294862
clearing focus key on menu close
04a30e43
making no results combobox placeholder readable byandroid screen reader
11e83672
fixing lint and updating comment in virtualizer
319694c5
Merge branch 'main' into combobox_testing_followups
866cffbd
fixing combobox no results test
7ab9787f
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
1ee60ed9
removing dupe code from merge
3c7b62ff
cleaning up imports
769e3b97
generating tray id once
fa03e3a5
making combobox input read only when mobile
5d14c3b4
fixing whitespace replacement in default filter
296d9ee9
Making listbox labelled by the label and its own aria label
02ca3e56
fixing test and removing menu styles from no results placeholder
0f840294
Fixing combobox page up/down and controlled open story
1c89d1a9
preventing collection from being focusable if sf shouldUseVirtualFocu…
8613f989
fixing tests
64860c14
fixing lint
b55413ef
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
11b8530f
updating combobox tray so it doesn't close on browser tab change
ad2d2937
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
d57d1c82
updating disabled keys combobox selection behavior and updating tests
39946a14
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
e4eadca4
Updating combobox tests to only use typeText
e9f68e7d
disabling collection focus behavior if autofocus is true but shouldUs…
d332b051
adding preventFocusOnPress to usePress
a8b107db
Merge branch 'preventFocusOnPress' of https://github.com/adobe/react-…
f93bfa4f
removing shouldUseVirtualFocus from usePress in favor of preventFocus…
49c75290
calling onCustomValue on Enter press for allowsCustomValue
69815364
prevent focusing the combobox trigger button on press
1c7c6ee0
fixing combobox tray so it opens on mobile tap
035b6715
stab at making voiceover cursor move to the combobox input consistent…
9092e9eb
Use visualViewport api to adjust tray height on iOS keyboard open
87b53d32
Removing opening menu on mobile focus
df02a79d
making menu remain open if user clears input text
1d7c7cfa
removing timeout on input refocusing on tray closure
e1b47769
preventing scroll on tray close
7f7e821e
making virtual clicks on combobox tray input close the tray
8dee9a2b
fixing lint and tests, adjusting tray so it still renders if visualVi…
13dd06d8
fixing voiceover double tap to open comboobox for ipad
1f4bee47
making virtual keyboard not show up for combobox input
1d11dab4
preventing onCustomValue from firing on Enter if it equals the curren…
2e161ba2
if user provided selectedKey prop is also in the disabled key set, a…
c216dfef
if user provided inputValue/defaultInputValue is also in the disabled…
806c6a8e
Addressing more issues
90f5ef00
Updating combobox stories for easier usage in ipad
32c95d03
Allowing user to re-enter the tray input via voiceover click without …
458c2f8e
adding tests and fixing tray closing on first virtual click if tray i…
051a6e69
fix lint
d24a7ed8
fixing tray close/open when user taps on empty tray space
67d151fa
making combobox input open on ipad voiceover virtual click
59f263a5
addressing review: adding preventFocusOnPress check to onclick for co…
14b019a0
Merge branch 'preventFocusOnPress' of https://github.com/adobe/react-…
204cf845
replacing inputMode=none with readonly true/false to suppress virtual…
81470d58
Merge branch 'main' of https://github.com/adobe/react-spectrum into c…
9ae7cc96
Merge branch 'combobox_testing_followups' of https://github.com/adobe…
299bff3c
Merge branch 'main' of github.com:adobe-private/react-spectrum-v3 int…
78689f22
devongovett
changed the base branch from
combobox_testing_followups
to
2020-v3-telemetry-rfc
4 years ago
Merge branch 'main' of github.com:adobe-private/react-spectrum-v3 int…
9ba37add
Move no results message into ComboBox instead of passing isMobile to …
8556a8de
Prevent multiple listbox items from having hover/focus styles at once
c72dab17
addressing falsy key case for page up/down in listlayout
7f2491ac
removing virtualizer scrollToItem offsetY
46b9e443
Remove aria-selected override from ListboxOption for further investig…
12007bbc
Fix tests
ee4252dd
Use a more narrow type for useLabels
29722cd8
devongovett
dismissed these changes
on 2020-10-07
Merge branch 'main' of github.com:adobe-private/react-spectrum-v3 int…
7dbfd5a0
devongovett
approved these changes
on 2020-10-07
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub