Numberfield followup #1029
devongovett
merged
108 commits into
main
from
numberfield-followup
WIP Numberfield
05fc5ca6
Rewrote a lot of the css, more will probably be needed as this doesn'…
19f3af57
Remove our own validation because it's too hard to enforce it ourselves
13fa1bf5
fix test and add one for invalid
c07e9269
Merge branch 'main' into numberfield-followup
b983837f
Add labels to stories
1766699f
reset jest exclude rule
0d739e2c
fix lint
15c91e20
Merge branch 'main' into numberfield-followup
b8558011
fixed remaining styles
77c59af8
round numbers so that onChange fires with the same value that is disp…
600aff72
majornista
requested changes
on 2020-10-05
Merge branch 'main' into numberfield-followup
9b305151
Supporting VO, it now reads the number when the stepper buttons are used
36ad251b
fix lint
9d762e2b
fix dependencies
c5c5238b
Borrow some code about mobile experiences
3c75d533
fix lint and TS
7aa15c4f
Merge branch 'main' into numberfield-followup
d6291127
Fix Firefox style for stepper buttons getting hidden
0fa0ccfe
remove unneeded z-index
341ce2b7
move focus to the input when the stepper buttons disable
b3462674
fix controlled state and updating of input text when formatter change…
34e1f5d5
add tests for the things i just fixed
e994772c
Merge branch 'main' into numberfield-followup
ea963654
Pushing fixes for:
5c6e792f
don't allow users to type a number that will land them outside the mi…
f2967de7
Add percent stories and tests
4446fe4d
Add support for starting incrementing/decrementing from 0 when unboun…
d0d1cdfc
Add support for Home and End
0a258e26
Add support to switch the inputMode from decimal to numeric if there …
500c0983
fixing all of the lint
9bd2362b
Reset typed value to controlled number value on blur
0ca35b4f
Let people type in a numeral system that isn't their locale's default
5ba16026
Merge branch 'main' into numberfield-followup
d898fe61
Map commonly used decimal characters to the right locale character
d04dc6f8
fix placeholder arabic text
e836546b
fix lint and tests
31f45312
Merge branch 'main' into numberfield-followup
a7e76197
fix lint and SSR
8bc7e75f
Fix arabic placeholder clipping in Chrome
587a9cba
Add translations so that various stories won't fail
2346b446
fix lint
a899e91f
move some code over to parser to help with generating parseable numbe…
b2394efe
Merge branch 'main' into numberfield-followup
4ce43f55
cleanup extraneous strings
d05602fc
fix lint and tests
cc89a691
code review comments
1233e40f
update from code review
c2b63749
Merge branch 'main' into numberfield-followup
cc6eec4f
code review code changes
2e4740aa
New safe values for percent min/max
10df6d17
reverse scroll direction
12cef307
add stories
59d3fa28
don't commit values before incrementing when clicking the stepper button
0802ac8a
keep minus sign for accounting in locales that don't support paren no…
7a821be5
Move from screen size to scale for showing steppers
8d05dce7
support rounding for negative numbers
e5693371
Add paste handling to selection restoring
74ca0bb7
Merge branch 'main' into numberfield-followup
bb1b744f
fix yarn install
6b600d0c
Merge branch 'numberfield-followup' of github.com:adobe/react-spectru…
77336ff5
two tests failing on the build server, checking why
1e404356
fix the build
a8e53771
Merge branch 'main' into numberfield-followup
91de3d2e
fix SSR test
286b5947
support any whitespace
18a92676
redo stepper buttons to be div's to avoid safari pointer bugs
398a0517
remove unused css
2ca2aca8
Fix focus on new stepper buttons
4b56c5ed
fix bounding behavior for percents
9b6be64a
Merge branch 'main' into numberfield-followup
cbd50716
fix lint
2441289a
Fix icons
fe985431
fix lint
649aa240
parse cleans unicode whitespace now
4dcd7ccc
improve comments
aa44e1a7
clean up last really bad comment
3c014e65
Update to Field
0bf89c50
Merge branch 'main' into numberfield-followup
cd64680b
Fix ref passing for Field and revert Field itself
2fd7205a
Merge branch 'main' into numberfield-followup
366145db
Fix applied style/classnames through Field
62bc3d4c
NumberField: fix accessibility role and aria-value* props (#1320)
f4d54770
Merge main
83f85021
Merge branch 'numberfield-followup' of github.com:adobe/react-spectru…
bce6bb47
fix version
08747c39
fix more versions of live announcer
4f71f535
support mobile quiet
8d1ff5cd
Fix deps, lint, and tests
e99b5752
Support full keyboard when negative numbers are allowed in mobile
adfbbe72
support in/decrementing from currently typed but uncommitted value
50f28ad6
Merge branch 'main' into numberfield-followup
ee89893a
adding a comment
58721b44
majornista
dismissed these changes
on 2020-12-03
Update packages/@react-aria/i18n/src/useNumberFormatter.ts
abde47bd
Update packages/@react-aria/i18n/src/useNumberParser.ts
fe3c84a2
Merge branch 'main' into numberfield-followup
b5d07111
Move clean into the parser
f0caddfd
Rename isChained to isSpinning to clarify role of variable
37e65dfa
add back focus tracking logic until something better can be done
fdf3b567
Stop focusing the input when the steppers are pressed
426f848f
Merge branch 'main' into numberfield-followup
8b050921
Splitting out into other PR's and general CSS cleanup
e6c8eb0c
Remove need to add 'isSpinning' to our API
a8663936
Move aria out of stately for numberfield
9801a9d3
fix import
138489bf
Merge branch 'main' into numberfield-followup
6aa9a194
Move types around and set state through stately, even if it can't ful…
fe5f063f
Merge Main
b835503d
devongovett
approved these changes
on 2021-01-20
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub