react-spectrum
Upgrade support for react 17
#1040
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
29
Changes
View On
GitHub
Upgrade support for react 17
#1040
devongovett
merged 29 commits into
main
from
pass-react-17-in-jest
snowystinger
requested a review
from
dannify
6 years ago
snowystinger
requested a review
from
devongovett
6 years ago
snowystinger
changed the base branch from
main
to
cleanup-tests
6 years ago
Base automatically changed from
cleanup-tests
to
main
6 years ago
snowystinger
changed the title
[WIP] - Upgrade support for react 17
Upgrade support for react 17
6 years ago
solimant
dismissed these changes on 2020-09-16
snowystinger
dismissed their stale review via
0c9967bc
5 years ago
[WIP] Upgrade to react 17 support
9593991f
remove unneeded chalk patch now that we are using the new version
9d5edcc8
fix a ref to the new way of doing things
243e1313
fix sidenav tests
ee383a78
Queue up useId updates to fix bad setState
f144a710
Adding a bunch of comments explaining things so that i don't lose my …
f3edb0c9
make sure to clean up listeners
319ebc72
We can leave these not capturing for now, no tests are failing currently
2b407b80
one more comment
3b3d8d68
Trying to find the node error stack
a6e41f82
Fixes the remainder of the tests, however, i need to add one now for …
fd8d1be1
put us back on react 16, with allowance for 17, i'll add circlci job …
e46728e4
reduce updates and fix yarn lock
6a72b6f3
Got a working scenario for 17
55cc73fc
Fix up useId so that it runs immediately if it's not in a render cycle
6a569fc2
fix lint
85ce3a88
Adding test
16052a49
can not put NODE_ENV before the yarn add command, it causes icons to …
fdf17b9b
correct range dep for root package
4576e755
fix yarn lock
75409cee
Increase timeout time so we can pass our tests. Will make issue to ad…
9ccf2cf2
remove unneeded chalk patch now that we are using the new version
2e1d920c
snowystinger
force pushed
from
0c9967bc
to
2e1d920c
5 years ago
remove stale comment
3f00c580
remove more stale comments
cebffd53
Merge branch 'main' into pass-react-17-in-jest
4c594903
Merge branch 'main' into pass-react-17-in-jest
481dbc86
fix syntax error from merge
b70e050a
devongovett
approved these changes on 2020-09-29
Merge branch 'main' into pass-react-17-in-jest
ed0f7a12
Merge branch 'main' into pass-react-17-in-jest
6a00b915
devongovett
merged
471eba32
into main
5 years ago
devongovett
deleted the pass-react-17-in-jest branch
5 years ago
Login to write a write a comment.
Login via GitHub
Reviewers
devongovett
solimant
dannify
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub