react-spectrum
ComboBox refactoring
#1176
Merged
Overview
Commits
39
Changes
View On GitHub

ComboBox refactoring #1176

dannify merged 39 commits into main from combobox-stuff
devongovett
devongovett WIP: refactor mobile combobox
c3702617
devongovett ComboBox state refactor
bd907ad0
devongovett Merge branch 'main' of github.com:adobe-private/react-spectrum-v3 int…
0d840f70
devongovett Add live region announcer for more consistent announcement with Voice…
78d7c076
devongovett Add missing strings to translations files
49f42782
devongovett Updates for mobile combobox and add tests
39be0d7a
devongovett Add aria-hidden to all elements other than combobox and popover when …
d49d65b0
devongovett Fix some TS issues
4e0fd6d0
devongovett Fix tray size on chrome android
7c3cf41e
devongovett Lint
e4949c57
devongovett Fix tests
1d632985
devongovett devongovett changed the title CombBox refactoring ComboBox refactoring 5 years ago
adobe-bot
devongovett Move ariaHideOutside into @react-aria/overlays
7268ba08
adobe-bot
devongovett Support placeholder in mobile combobox
42c00415
devongovett Close when clicking on the button a second time
e517691f
devongovett Various code cleanup and ref handling improvements
00c14c14
devongovett Correct aria-setsize with sections
288cf8ce
devongovett Make live announcer behave more consistently
e60d43ce
devongovett Only use live announcer on apple devices
d9adcc8e
devongovett lint
43796993
adobe-bot
devongovett Preserve defaultInputValue prop on initial render even if the default…
ea8f7d7b
adobe-bot
devongovett devongovett marked this pull request as ready for review 5 years ago
devongovett devongovett requested a review from dannify dannify 5 years ago
devongovett devongovett requested a review from snowystinger snowystinger 5 years ago
devongovett Remove tabIndex from listbox and options when using virtual focus
3d82fda7
devongovett Only blur input on touch scroll
cbfcc593
devongovett Make clear button not overlap validation icon in searchfield
2cbcb394
devongovett Pass through style to ComboBoxInput so custom width without label works
7856e46e
devongovett Fix disabled styling of mobile combobox
9418ee9e
devongovett Don't let long values wrap in mobile combobox
cab47b43
devongovett Fix page up/page down in combobox
5d5eb89d
devongovett Mobile combobox fixes
5153bb91
devongovett Calculate overlay positions based on visual viewport
73535b42
devongovett Fix custom width
0c49317d
devongovett Focus button when clicking on label on mobile
107650e6
devongovett Prevent focus on clear button
98c4bf58
devongovett Add label for invalid icon on mobile
25502813
devongovett Merge branch 'main' of github.com:adobe-private/react-spectrum-v3 int…
d70f0130
devongovett lint
02d29290
devongovett Fix ComboBox tests
9b70ed7f
devongovett Fix useOverlayTrigger tests
c32a9b35
LFDanLu fix docs build by fixing clearbutton type
0a5db501
adobe-bot
dannify Merge branch 'main' into combobox-stuff
8bbc11a5
adobe-bot
dannify
dannify approved these changes on 2020-11-06
dannify dannify merged 28ceccbf into main 5 years ago
dannify dannify deleted the combobox-stuff branch 5 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum