ComboBox bug fixes #1449
devongovett
merged
24 commits into
main
from
issue_1443
preventing onOpenChange from triggering if there are no items
e6f58652
tentative fix for closing the menu when entering custom value
7fec7d05
fixing combobox story
8e9a4481
calling onSelectionChange in commitCustomValue instead
06756303
making readonly mobile combobox not open on press
4405f716
closing menu if user clicks an already selected option
88747dfc
initializing useComboBoxState lastSelectedKey ref and fixing tests
34bfdd90
reseting inputValue if user selects a previously select item with Enter
807953f3
resetting inputValue if user selects a selected item with click
e6195805
fixing a story bug
3603fd71
LFDanLu
commented
on 2021-01-12
Merge branch 'main' into issue_1443
84b3ea26
Making combobox menu always close if blur happens via click
a529ef79
addressing review comments
55637171
Merge branch 'main' into issue_1443
6bdd6843
Merge branch 'main' into issue_1443
715f69c5
LFDanLu
commented
on 2021-01-20
only calling commitCustomValue when allowsCustomValue is true
86348c5d
LFDanLu
commented
on 2021-01-21
LFDanLu
commented
on 2021-01-21
devongovett
commented
on 2021-01-20
addressing review comments
7628111f
Merge branch 'main' of https://github.com/adobe/react-spectrum into i…
02084236
Merge branch 'main' into issue_1443
2d3b9cc1
fixing combobox menu item sizing when isOpen is true
76c8dbd3
Merge branch 'issue_1443' of https://github.com/adobe/react-spectrum …
f1382e69
LFDanLu
commented
on 2021-01-26
LFDanLu
commented
on 2021-01-26
Merge branch 'main' into issue_1443
0ba81506
Merge branch 'main' into issue_1443
33e957b2
Revert "fixing combobox menu item sizing when isOpen is true"
de61e7ef
devongovett
approved these changes
on 2021-02-01
razvanip
commented
on 2021-02-01
Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Login to write a write a comment.
Login via GitHub